Skip to content

Ignore all debuginfo tests for LLDB that we do not run in CI#152010

Open
workingjubilee wants to merge 1 commit intorust-lang:mainfrom
workingjubilee:what-does-the-scouter-say-about-the-lldb-version-level
Open

Ignore all debuginfo tests for LLDB that we do not run in CI#152010
workingjubilee wants to merge 1 commit intorust-lang:mainfrom
workingjubilee:what-does-the-scouter-say-about-the-lldb-version-level

Conversation

@workingjubilee
Copy link
Member

@workingjubilee workingjubilee commented Feb 2, 2026 •
edited
Loading

We only run LLDB 1500 in CI. Any test with a min-lldb-version above that is currently ignored. It's not clear any of these tests actually work with that LLDB version, and they definitely don't work on LLDB ~2100. So, ignore them until we fix debuginfo testing.

Fixes #151966

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 2, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Zalathar
Copy link
Member

Zalathar commented Feb 2, 2026

I haven’t checked that it actually works, but I think we already have an //@ ignore-lldb directive which is effectively this but more explicit.

@workingjubilee workingjubilee force-pushed the what-does-the-scouter-say-about-the-lldb-version-level branch from f479cb7 to b441a5d Compare February 2, 2026 22:12
@workingjubilee
Copy link
Member Author

workingjubilee commented Feb 2, 2026

Yep, that works!

@workingjubilee workingjubilee force-pushed the what-does-the-scouter-say-about-the-lldb-version-level branch from b441a5d to d978dd6 Compare February 2, 2026 22:15
workingjubilee
workingjubilee commented Feb 2, 2026
View reviewed changes
tests/debuginfo/opt/dead_refs.rs
@@ -1,4 +1,4 @@
//@ min-lldb-version: 1800
//@ ignore-lldb
Copy link
Member Author

@workingjubilee workingjubilee Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now using ignore-lldb for all cases, and found this case also.

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Feb 2, 2026

Can we either put this in compiletest or leave an annotation for the ones that are lldb-version related? I expect we have some tests that are already ignored for other reasons on lldb and it would be nice to distinguish those cases, I think.

@workingjubilee
Copy link
Member Author

workingjubilee commented Feb 2, 2026

I mean, the min-lldb-version: 9000 variant was pretty distinctive!

I'll add a comment.

@workingjubilee
Ignore all debuginfo tests for LLDB that we do not run in CI
2b0cce0 
We only run LLDB 1500 in CI. Any test with a min-lldb-version above that
is currently ignored. It's not clear any of these tests actually work
with that LLDB version, and they definitely don't work on LLDB ~2100.
So, ignore them until we fix debuginfo testing.
@workingjubilee workingjubilee force-pushed the what-does-the-scouter-say-about-the-lldb-version-level branch from d978dd6 to 2b0cce0 Compare February 3, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LLDB testing should be disabled

4 participants

@workingjubilee @rustbot @Zalathar @Mark-Simulacrum